-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: convert widget into compound components #630
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #630 +/- ##
=======================================
Coverage 23.72% 23.72%
=======================================
Files 165 165
Lines 6178 6178
Branches 335 335
=======================================
Hits 1466 1466
Misses 4712 4712
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good instance of when compound components are great, thanks @tigranpetrossian
I wonder if you'd fancy writing a Coding Convention page on how we should use this pattern (and how we shouldn't).
Definitely! Will get to it during the week. |
Great work @tigranpetrossian 👏 |
Part of LEA-659
Converts the Widget into a Radix-style compound component in preparation for list item animations, but also in an attempt to standardize with other similar components like the Approver
Before
After
This significantly reduces the prop drilling and subsequently the need to expose more props, de-couples it from ScrollView, some spacing opinions (padding, gaps, etc.), and replaces the dependency on
sheet
with a generic action.