-
-
Notifications
You must be signed in to change notification settings - Fork 230
Translations update from Hosted Weblate #846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Currently translated at 98.9% (276 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/he/
Currently translated at 99.6% (278 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/he/
Currently translated at 97.8% (273 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/ta/
Currently translated at 100.0% (279 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/ta/
Currently translated at 97.8% (273 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/fr/
Currently translated at 100.0% (279 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/he/
Currently translated at 100.0% (279 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/he/
Currently translated at 100.0% (279 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/nl/
Currently translated at 100.0% (279 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/nl/
Currently translated at 100.0% (279 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/nl/
Currently translated at 100.0% (279 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/nl/
Currently translated at 100.0% (279 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/nl/
Currently translated at 18.6% (52 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/ko/
Currently translated at 18.6% (52 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/ko/
Currently translated at 18.6% (52 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/ko/
Currently translated at 18.6% (52 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/ko/
Currently translated at 18.6% (52 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/ko/
Currently translated at 18.6% (52 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/ko/
WalkthroughNew Korean localization strings were added to the MeetingBar app’s resource file. These include UI labels, shortcut descriptions, patronage and support prompts, event appearance options, and various display styles. No existing strings were changed or removed; only new key-value pairs were appended. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (3)
MeetingBar/Resources /Localization /ko.lproj/Localizable.strings (3)
39-39
: Improve clarity of “non-all-day events” translation“기타 이벤트” literally means “other events” and does not convey the intended “non-all-day” meaning.
-"preferences_appearance_events_non_all_day_title" = "기타 이벤트:"; +"preferences_appearance_events_non_all_day_title" = "종일이 아닌 이벤트:";
40-41
: Natural-sounding Korean for link-less eventsCurrent phrasing is awkward (“회의를 연결할 수 없으면”). Using “회의 링크가 없으면” is more idiomatic.
-"preferences_appearance_events_value_inactive_without_meeting_link" = "회의를 연결할 수 없으면 비활성화"; -"preferences_appearance_events_value_hide_without_meeting_link" = "회의를 연결할 수 없으면 숨기기"; +"preferences_appearance_events_value_inactive_without_meeting_link" = "회의 링크가 없으면 비활성화"; +"preferences_appearance_events_value_hide_without_meeting_link" = "회의 링크가 없으면 숨기기";
45-45
: Add “중” for natural flow“보류 이벤트” sounds slightly abrupt; “보류 중인 이벤트” is the common Korean wording.
-"preferences_appearance_events_pending_title" = "보류 이벤트"; +"preferences_appearance_events_pending_title" = "보류 중인 이벤트:";
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
MeetingBar/Resources /Localization /ko.lproj/Localizable.strings
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: GitGuardian Security Checks
- GitHub Check: Codacy Security Scan
🔇 Additional comments (1)
MeetingBar/Resources /Localization /ko.lproj/Localizable.strings (1)
20-32
: Overall additions look consistentNew shortcut and patronage strings follow existing naming conventions and key style. No structural or formatting issues detected.
"preferences_general_shortcut_join_from_clipboard" = "클립보드의 회의 참석:"; | ||
"preferences_general_shortcut_toggle_meeting_name_visibility" = "메뉴 막대에서 제목 표시 토글:"; | ||
"preferences_general_external_patronage" = "후원"; | ||
"preferences_general_external_contact" = "Contact"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
"Contact" is left untranslated
Keeping a lone English word inside an otherwise-Korean preferences pane breaks consistency and may look like an unfinished localisation.
-"preferences_general_external_contact" = "Contact";
+"preferences_general_external_contact" = "연락처";
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
"preferences_general_external_contact" = "Contact"; | |
"preferences_general_external_contact" = "연락처"; |
🤖 Prompt for AI Agents
In MeetingBar/Resources/Localization/ko.lproj/Localizable.strings at line 25,
the string "Contact" is untranslated and appears in English within the Korean
localization file. Replace the English word "Contact" with its correct Korean
translation to maintain consistency and completeness of the localization.
Currently translated at 52.3% (146 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/ko/
Currently translated at 52.3% (146 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/ko/
Currently translated at 52.3% (146 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/ko/
Currently translated at 52.3% (146 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/ko/
Currently translated at 52.3% (146 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/ko/
Currently translated at 52.3% (146 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/ko/
Currently translated at 52.3% (146 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/ko/
Currently translated at 52.3% (146 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/ko/
Currently translated at 52.3% (146 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/ko/
Currently translated at 52.3% (146 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/ko/
Currently translated at 52.3% (146 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/ko/
Currently translated at 52.3% (146 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/ko/
Currently translated at 81.0% (226 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/ko/
Currently translated at 81.0% (226 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/ko/
Currently translated at 81.0% (226 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/ko/
Currently translated at 81.0% (226 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/ko/
Currently translated at 81.0% (226 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/ko/
Currently translated at 81.0% (226 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/ko/
Currently translated at 81.0% (226 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/ko/
Currently translated at 81.0% (226 of 279 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/ko/
Translations update from Hosted Weblate for MeetingBar/App.
Current translation status:
Summary by CodeRabbit