-
-
Notifications
You must be signed in to change notification settings - Fork 230
Update Localizable.strings #849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
added missing translation for German
WalkthroughA new German localization string was added to the MeetingBar app's resource files. The entry provides a translation for an action related to dismissing or discarding an event notification. No other strings or code were modified. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
MeetingBar/Resources /Localization /de.lproj/Localizable.strings (1)
16-16
: Consider aligning wording with existing action stringsElsewhere in the file, comparable actions avoid the demonstrative pronoun (“Meeting verwerfen”, “Dismissal entfernen”).
For consistency and to keep the label concise, prefer simply:-"notifications_meetingbar_dismiss_event_action" = "Dieses Ereignis verwerfen"; +"notifications_meetingbar_dismiss_event_action" = "Ereignis verwerfen";This mirrors the terse imperative style used throughout the German localisation.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
MeetingBar/Resources /Localization /de.lproj/Localizable.strings
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Codacy Security Scan
Thanks, @fbolte ! |
added missing translation for German
Status
READY
Description
Just added a string for German translation
Checklist
Steps to Test or Reproduce
Can't build. I'm not a developer, just added a line of text.
Summary by CodeRabbit