Skip to content

Commit

Permalink
Merge pull request prometheus#13336 from machine424/flakky
Browse files Browse the repository at this point in the history
scrape_test.go: Increase scrape interval in TestScrapeLoopCache
to reduce potential flakiness.
  • Loading branch information
bboreham authored Jan 18, 2024
2 parents b9952ff + 2f60177 commit 4ad9b6d
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion scrape/scrape_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1211,7 +1211,9 @@ func TestScrapeLoopCache(t *testing.T) {
)

ctx, cancel := context.WithCancel(context.Background())
sl := newBasicScrapeLoop(t, ctx, scraper, app, 10*time.Millisecond)
// Decreasing the scrape interval could make the test fail, as multiple scrapes might be initiated at identical millisecond timestamps.
// See https://github.com/prometheus/prometheus/issues/12727.
sl := newBasicScrapeLoop(t, ctx, scraper, app, 100*time.Millisecond)

numScrapes := 0

Expand Down

0 comments on commit 4ad9b6d

Please sign in to comment.