FIX : Connection defaultDatabase #238
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te-mongodb-to-version-6 feat(mongodb): update to version 6
the file follows docker compose specification at https://docs.docker.com/compose/compose-application-model/#the-compose-file -
…ker-compose-yml chore: upgrade docker compose yaml file
this driver adds support to mongodb 7.0 and php 8.3
…p-mongodb-driver chore: bump mongodb extension and lib to v1.17.0
Method findDefaultDatabase was moved from getClient to __construct. Since $defaultDatabase is pulled from Manager before getClient was called, causing the wrong schema name being used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection was updating its internal property $defaultDatabase inside the method getClient().
Manager pulls the variable during setConnection(), with happens before connection->getClient() is called.
This cause the effect of not updating the defaultDatabase in time to be used on valid database exchanges. Causing the schema to always be called 'mongolid'.
This change updates the Connect->defaultDatabase during instantiation throught the __construct method. Updating the information in time to be pulled by Manager during setConnection.
Causing connection strings like this :
$manager->setConnection(new Connection('mongodb://192.168.1.202:27017/WGL'));
To work correctly using WGL as the schema name.
Please let me know if this PR is acceptable, or how can I correct it.
Best regards.