Setting the random seed every time is not a good idea

[ufownl]

Remove math.randomseed call from totp_new_key function.

[leslie-tsang]

Yes, would be better to init math.randomseed at the beginning of the module instead of function call. :)

[ufownl]

Calling it at the beginning of the module may change the user's fixed seed, so it might be a better choice to let users call it themselves.

[leslie-tsang]

so it might be a better choice to let users call it themselves.

I'm afraid that's not a good way to handle this, which require the user to be familiar with the library's implementation. :)

[ufownl]

Indeed, a better approach is to use a separate random generator in each instance so that it can independently set a fixed seed or a random one. However, Lua's built-in random generator is global, and implicitly setting the random seed can cause many problems.

[leslie-tsang]

setting the random seed can cause many problems.

That's a bit of an overstatement in the real world. you should never expect a exact result of RNG, even a PRNG. :)

It shouldn't cause any issue as the random number seeds are not duplicated in such a scenario.

[ufownl]

1. In some cases, when we need reproducible results, the fixed random seed is required. This is very common in machine learning or debugging, etc.
2. In OpenResty, users may load modules during the initialization phase of the master process, and then the same seed that is set implicitly will be forked to the worker processes, so they still need to re-set the seed in each worker process.

It should be common sense to set the seed before all random operations. Setting it implicitly when loading the module does not simplify usage and introduces global side effects. I don't think this is a good way.

[leslie-tsang]

Sounds fair, let's move it to a separate function and add test cases.
Would you like to take over? :)

[ufownl]

Ok, I should be able to do it tomorrow. :)

[ufownl]

unit-test (ubuntu-18.04, *) actions seem to have been queued for a long time, maybe they need manual intervention.

[leslie-tsang]

unit-test (ubuntu-18.04, *) actions seem to have been queued for a long time, maybe they need manual intervention.

Yep, I will fix it. :)

[leslie-tsang]

LGTM