-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: support for HTTP and gRPC tracing exporters in setup_tracing #2645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fredzolio
wants to merge
2,540
commits into
letta-ai:main
Choose a base branch
from
fredzolio:feat/otel_http_option
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…run postgres inside `app.ts` (letta-ai#1373)
Co-authored-by: Sarah Wooders <[email protected]>
Co-authored-by: Sarah Wooders <[email protected]> Co-authored-by: Shubham Naik <[email protected]> Co-authored-by: Shubham Naik <[email protected]> Co-authored-by: Charles Packer <[email protected]>
Co-authored-by: Matthew Zhou <[email protected]> Co-authored-by: Andy Li <[email protected]>
This commit brings back the changes introduced in commit ec95703, which were missing in the current main branch since 546996e. Co-authored-by: Miao <[email protected]>
…tta-ai#1898) fix: FastAPI router ordering for sources and tools
letta-ai#1880) docs: reorganize embedding models
Thanks for your contribution! |
sarahwooders
pushed a commit
that referenced
this pull request
Jun 6, 2025
b6907a4
to
ae775db
Compare
carenthomas
pushed a commit
that referenced
this pull request
Sep 15, 2025
carenthomas
pushed a commit
that referenced
this pull request
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the purpose of this pull request.
This PR adds support for exporting OpenTelemetry traces using the HTTP protocol in addition to the existing gRPC option. The
setup_tracing
function now detects if the provided endpoint starts with "http" and configures the appropriate OTLP exporter (HTTP or gRPC) accordingly.Is it to add a new feature? Is it to fix a bug?
This is a new feature. It enhances the tracing setup by allowing the use of HTTP endpoints for OTLP trace exporting, increasing compatibility with different observability backends.
How to test
http://localhost:4318/v1/traces
) in your configuration or environment.Have you tested this PR?
Yes, I have tested the latest commit. When using an HTTP endpoint, traces are successfully exported via HTTP. When using a gRPC endpoint, traces are exported via gRPC as before. No errors were observed in the logs.
Related issues or PRs
No related issues or PRs at this time.
Is your PR over 500 lines of code?
No, this PR is well under 500 lines of code.
Additional context
This change improves flexibility for deployments where only HTTP OTLP endpoints are available or preferred. No breaking changes were introduced.