Skip to content

Conversation

shourya-mukherjee
Copy link

Please describe the purpose of this pull request.
Support tool rules with pre-defined inputs

How to test
pytest -s tests/test_managers.py -k 'test_predefined_args_zero_llm_usage'

Have you tested this PR?
Yea

Related issues or PRs

#2716

Is your PR over 500 lines of code?
If so, please break up your PR into multiple smaller PRs so that we can review them quickly, or provide justification for its length.

Additional context
Add any other context or screenshots about the PR here.

carenthomas and others added 30 commits June 6, 2025 11:05
cliandy and others added 22 commits July 3, 2025 10:41
Co-authored-by: Kian Jones <[email protected]>
Co-authored-by: Sarah Wooders <[email protected]>
Co-authored-by: Matthew Zhou <[email protected]>
Co-authored-by: Andy Li <[email protected]>
Co-authored-by: Kian Jones <[email protected]>
Co-authored-by: Sarah Wooders <[email protected]>
Co-authored-by: Matthew Zhou <[email protected]>
Co-authored-by: Andy Li <[email protected]>
Co-authored-by: Kian Jones <[email protected]>
Co-authored-by: Sarah Wooders <[email protected]>
Co-authored-by: Matthew Zhou <[email protected]>
Co-authored-by: Andy Li <[email protected]>
Co-authored-by: jnjpng <[email protected]>
Co-authored-by: Jin Peng <[email protected]>
Co-authored-by: cpacker <[email protected]>
Co-authored-by: Shubham Naik <[email protected]>
Co-authored-by: Shubham Naik <[email protected]>
Copy link
Collaborator

@sarahwooders sarahwooders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Make sure to test all modes: step streaming, token stream, and steps
  • Test mixing both parameter define and non-parameter defined tools
  • Only add the args for InitToolRule - for child tool rule maybe make a dictionary that is child_args?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.