refactor: migrate rethink_memory to native memory_rethink tool #3049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update batch processing to support both old and new tool names - Rename _bulk_rethink_memory_async to _bulk_memory_rethink_async - Add parameter conversion from target_block_label to label - Add deprecation warning to old rethink_memory function - Maintain backward compatibility for existing agents Addresses TODO comments about brittle implementation and need for native tool control
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the purpose of this pull request.
This PR addresses the TODO comments in letta_agent_batch.py by migrating the rethink_memory function to use the native memory_rethink tool.
improvements:
Removed hardcoded special handling for rethink_memory in batch processing
Uses the existing native memory_rethink tool from LettaCoreToolExecutor
Maintains full backward compatibility for existing agents
How to test
-Existing tests pass with the refactoring
-Run existing batch tests: uv run pytest -s tests/test_letta_agent_batch.py -v
-Test parameter conversion logic (old target_block_label → new label)-
-Also, Verify deprecation warning appears when using old rethink_memory function ,.
Have you tested this PR?
YES.
-Deprecation warning is displayed
-No breaking changes for existing agents
Related issues or PRs
No related issues. The purpose of this change is to addresses TODO comment directly in the codebase.
Is your PR over 500 lines of code?
No, 74aadditi0ns, 25 deleltions
Additional context
-The native memory_rethink alraedy existed, it just wasnt being used