Skip to content

Conversation

@RickiG
Copy link

@RickiG RickiG commented Mar 30, 2014

Excellent implementation Levi! Thanks. Why can't the UIPageViewController work like this:).
I subclassed it and found that without access to initPages() I couldn't apply a change to my data model.
So I added an updatePageLayout() method which calls initPages() internally, thought that best follows your naming convention.

@levigroker
Copy link
Owner

Thank you Ricki!

Sorry for the slow reply; I've been traveling.

You've illuminated an oversight on my behalf, as you experienced, there's currently no way to reload the current index view controller.

I think your proposed implementation is fine, but I wonder if 'updatePageLayout' is the right choice of names since it is more akin to 'reloadData' ala UITableView or UICollectionView in that it will request new information from the data source rather than just updating layout with the data it has.

If you agree, please change the 'updatePageLayout' method to 'reloadData' and I'd be happy to accept the pull.

Many thanks!

Levi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants