force layout after update to model #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you Ricki! Sorry for the slow reply; I've been traveling. You've illuminated an oversight on my behalf, as you experienced, there's currently no way to reload the current index view controller. I think your proposed implementation is fine, but I wonder if 'updatePageLayout' is the right choice of names since it is more akin to 'reloadData' ala UITableView or UICollectionView in that it will request new information from the data source rather than just updating layout with the data it has. If you agree, please change the 'updatePageLayout' method to 'reloadData' and I'd be happy to accept the pull. Many thanks! Levi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excellent implementation Levi! Thanks. Why can't the UIPageViewController work like this:).
I subclassed it and found that without access to initPages() I couldn't apply a change to my data model.
So I added an updatePageLayout() method which calls initPages() internally, thought that best follows your naming convention.