Build multi-platform eden-sdn image #1082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the sdn Makefile to support building eden-sdn images for multiple platforms using Docker Buildx and LinuxKit. Each target architecture now produces a distinct sdn-<arch>-bios.img and is handled via dedicated Makefile targets (e.g., build-vm-img-linux-arm64). Dockerfile.vm has been updated to use the correct image based on the target architecture at build time using the standard TARGETARCH argument. Signed-off-by: Milan Lenco <[email protected]>
milan-zededa
force-pushed
the
sdn-vm-image
branch
from
745e3fe to
44ddefb
Compare
uncleDecart
approved these changes
Jul 18, 2025
|
Merging to check if publish is fixed... |
|
Looks like it succeeded: https://github.com/lf-edge/eden/actions/runs/16373918250/job/46268972090 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the
sdn/Makefileto support buildingeden-sdnimages for multiple platforms using Docker Buildx and LinuxKit. Each target architecture now produces a distinctsdn-<arch>-bios.imgand is handled via dedicated Makefile targets (e.g.,build-vm-img-linux-arm64).Dockerfile.vmhas been updated to use the correct image based on the target architecture at build time using the standardTARGETARCHargument.With this patch it is now supported to specify multiple platforms, like we do in the publish workflow:
(my previous PR broke the multi-platform building/publishing: https://github.com/lf-edge/eden/actions/runs/16353910243/job/46207393649)