-
Notifications
You must be signed in to change notification settings - Fork 52
Vector integration tests #1083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Vector integration tests #1083
Conversation
11d90bc
to
7f06de9
Compare
Do you think we should also add the new tests to the Eden workflow? |
yes, I think it should be done when EVE with vector is released. |
Part of which Eden job will it be? |
I think it's gonna be a new step in the smoke suite. |
Ok, why is it draft? Can we merge it? |
This PR can be merged when an EVE version that includes a vector package is released and set as default for Eden. |
I think we can still merge it and just update the Eden version in EVE later. |
Then we will have broken test in Eden workflows |
ok, let's wait |
We have internal dependency on testing package that was changed in go version 1.23 Signed-off-by: Paul Gaiduk <[email protected]>
Those binaries are used when running tests and don't need to be checked into git. Signed-off-by: Paul Gaiduk <[email protected]>
The config Eve.AdamLogLevel is confusing and without context might be mistaken for the log level of the Adam service. Renaming it to Eve.RemoteLogLevel makes it more consistent with EVE's own config parameter RemoteLogLevel. Signed-off-by: Paul Gaiduk <[email protected]>
Added the following functions: - `UpdateNodeGlobalConfig` - `GetConfig` - `SetConfig` - `WaitForConfigApplied` Signed-off-by: Paul Gaiduk <[email protected]>
FindLogOnAdam queries Adam for specified log entry. The user can query the past or future logs and specify a timeout. Signed-off-by: Paul Gaiduk <[email protected]>
I think it's ready... |
Added a test that checks a valid config is applied correctly, then sets a faulty config and checks that vector detects that and reapplies the valid config again. Added a test to verify that vector restores it's default configuration when no configuration is provided. This is useful for restoring the default configuration in case something goes wrong. Added a test that applies a filter config to filter out periodic logs from chrony and verifies that the filter is applied correctly and the logs no longer appear at the controller. Signed-off-by: Paul Gaiduk <[email protected]>
Added vector tests to the smoke tests suite. Updated the EVE tag to 15.8.0 since that's the first version to include vector. Signed-off-by: Paul Gaiduk <[email protected]>
7f06de9
to
d7cf757
Compare
I think we need to wait for EVE 15.8.0, since the version before it will not include vector and the tests added here will fail in this repo. |
@OhmSpectator I already increase the default EVE version in this PR to 15.8.0, so we can merge as soon as this release is cut. That's why Eden_setup job fails for now. |
@europaul we can run those tests as |
yap. And in a dozen other different ways that we support 😆 |
Just two :) Once I get confirmation from @andrewd-zededa this can go in and we can switch to run just go test |
Here I added some end-to-end tests for the vector package. The tests include:
This PR can be merged when an EVE version that includes a vector package is released and set as default for Eden.