Skip to content

Vector integration tests #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

europaul
Copy link
Contributor

@europaul europaul commented Jul 18, 2025

Here I added some end-to-end tests for the vector package. The tests include:

  • applying a faulty config and seeing how vector recovers
  • applying an empty config and checking if vector restores the default one
  • applying a working config and checking it's effects

This PR can be merged when an EVE version that includes a vector package is released and set as default for Eden.

@europaul europaul requested a review from OhmSpectator July 18, 2025 14:36
@europaul europaul mentioned this pull request Jul 18, 2025
6 tasks
@europaul europaul force-pushed the vector-integration-tests branch from 11d90bc to 7f06de9 Compare July 18, 2025 14:42
@OhmSpectator
Copy link
Member

Do you think we should also add the new tests to the Eden workflow?

@europaul
Copy link
Contributor Author

yes, I think it should be done when EVE with vector is released.
but actually they rely a lot on SSHing into EVE and since this is the most flaky part of our Eden testing I expect they will fail a lot

@OhmSpectator
Copy link
Member

Part of which Eden job will it be?

@europaul
Copy link
Contributor Author

Part of which Eden job will it be?

I think it's gonna be a new step in the smoke suite.

@OhmSpectator
Copy link
Member

Ok, why is it draft? Can we merge it?

@europaul
Copy link
Contributor Author

Ok, why is it draft? Can we merge it?

This PR can be merged when an EVE version that includes a vector package is released and set as default for Eden.

@OhmSpectator
Copy link
Member

I think we can still merge it and just update the Eden version in EVE later.

@uncleDecart
Copy link
Member

I think we can still merge it and just update the Eden version in EVE later.

Then we will have broken test in Eden workflows

@OhmSpectator
Copy link
Member

ok, let's wait

europaul added 5 commits July 25, 2025 14:38
We have internal dependency on testing package that was changed in go
version 1.23

Signed-off-by: Paul Gaiduk <[email protected]>
Those binaries are used when running tests and don't need to
be checked into git.

Signed-off-by: Paul Gaiduk <[email protected]>
The config Eve.AdamLogLevel is confusing and without context might be
mistaken for the log level of the Adam service. Renaming it to
Eve.RemoteLogLevel makes it more consistent with EVE's own config
parameter RemoteLogLevel.

Signed-off-by: Paul Gaiduk <[email protected]>
Added the following functions:
- `UpdateNodeGlobalConfig`
- `GetConfig`
- `SetConfig`
- `WaitForConfigApplied`

Signed-off-by: Paul Gaiduk <[email protected]>
FindLogOnAdam queries Adam for specified log entry. The user can query
the past or future logs and specify a timeout.

Signed-off-by: Paul Gaiduk <[email protected]>
@OhmSpectator
Copy link
Member

I think it's ready...

@OhmSpectator OhmSpectator marked this pull request as ready for review July 25, 2025 14:27
europaul added 2 commits July 25, 2025 19:08
Added a test that checks a valid config is applied correctly,
then sets a faulty config and checks that vector detects
that and reapplies the valid config again.

Added a test to verify that vector restores it's default configuration
when no configuration is provided. This is useful for restoring the
default configuration in case something goes wrong.

Added a test that applies a filter config to filter out periodic logs
from chrony and verifies that the filter is applied correctly and the
logs no longer appear at the controller.

Signed-off-by: Paul Gaiduk <[email protected]>
Added vector tests to the smoke tests suite.
Updated the EVE tag to 15.8.0 since that's the first version to include
vector.

Signed-off-by: Paul Gaiduk <[email protected]>
@europaul europaul force-pushed the vector-integration-tests branch from 7f06de9 to d7cf757 Compare July 25, 2025 17:12
@europaul
Copy link
Contributor Author

I think it's ready...

I think we need to wait for EVE 15.8.0, since the version before it will not include vector and the tests added here will fail in this repo.

@europaul
Copy link
Contributor Author

europaul commented Jul 25, 2025

@OhmSpectator I already increase the default EVE version in this PR to 15.8.0, so we can merge as soon as this release is cut. That's why Eden_setup job fails for now.

@uncleDecart
Copy link
Member

@europaul we can run those tests as go test, right?

@europaul
Copy link
Contributor Author

@europaul we can run those tests as go test, right?

yap. And in a dozen other different ways that we support 😆

@uncleDecart
Copy link
Member

@europaul we can run those tests as go test, right?

yap. And in a dozen other different ways that we support 😆

Just two :) Once I get confirmation from @andrewd-zededa this can go in and we can switch to run just go test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants