Remove continue-on-error so job failures fail the workflow. #1085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The smoke, storage and eve-upgrade jobs no longer ignore step errors, ensuring any failing job marks the whole workflow as failed. To keep all matrix permutations running, each job’s strategy now explicitly sets fail-fast: false. This preserves full test coverage without cancelling siblings early while still surfacing problems in red at the workflow level. Signed-off-by: Nikolay Martyanov <[email protected]>
OhmSpectator
force-pushed
the
fix/do-not-allow-error-in-steps
branch
from
96aa8b3 to
2561237
Compare
|
The initial idea of that was that it takes us multiple runs to make them work, do you think that eden tests are stable enough to enable that? |
|
It does not affect the Eden runs much. It still allows tests to continue if any job fails. It just doesn't mark a job as successful if one of its steps fails. We had used the wrong approach to preserve the matrix functionality. |
europaul
approved these changes
Jul 22, 2025
uncleDecart
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The smoke, storage and eve-upgrade jobs no longer ignore step errors, ensuring any failing job marks the whole workflow as failed. To keep all matrix permutations running, each job’s strategy now explicitly sets fail-fast: false. This preserves full test coverage without cancelling siblings early while still surfacing problems in red at the workflow level.