Skip to content

Fix Eden workflow schema and drop redundant IP logging. #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025

Conversation

OhmSpectator
Copy link
Member

@OhmSpectator OhmSpectator commented Jul 22, 2025

Declare the Eden test workflow call at the job level instead of nesting it inside steps, correcting the GitHub Actions schema that had broken the job. Remove the temporary “Print Public IP Address” command, now handled centrally across all Eden jobs in test.yml.

These changes restore a valid workflow file and re-enable automatic Eden tests for pull-request builds.

It partially reverts 1bfe493 from #1080

@OhmSpectator OhmSpectator requested a review from rene July 22, 2025 07:45
Declare the Eden test workflow call at the job level instead of nesting
it inside steps, correcting the GitHub Actions schema that had broken
the job.  Remove the temporary “Print Public IP Address” command, now
handled centrally across all Eden jobs in test.yml.

These changes restore a valid workflow file and re-enable automatic Eden
tests for pull-request builds. It partially reverts 1bfe493.

Signed-off-by: Nikolay Martyanov <[email protected]>
@OhmSpectator OhmSpectator force-pushed the fix/fix-eden-workflow branch from aac4329 to 13c544f Compare July 22, 2025 07:46
@uncleDecart
Copy link
Member

Thanks for the fix!

@uncleDecart uncleDecart merged commit cdd96cb into lf-edge:master Jul 22, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants