Skip already passed tests using GH API #1087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uncleDecart
reviewed
Jul 22, 2025
7 tasks
OhmSpectator
force-pushed
the
feature/self-made-rerun
branch
from
57d23fd to
7748011
Compare
|
I'll test it in Rene's repo first:https://github.com/rene/eden/actions/runs/16448206031/job/46486153891?pr=2 |
|
No, it does not work as expected... |
OhmSpectator
changed the title
OhmSpectator
force-pushed
the
feature/self-made-rerun
branch
from
5e40f9c to
39fc0b5
Compare
Add logic to detect whether a job has already succeeded in a previous workflow attempt using the GitHub Actions API. This enables us to use the "Rerun all jobs" button without re-running already successful jobs. We currently report commit status manually in a parent workflow. If "Rerun failed jobs" is used, GitHub postpones execution of the status reporting step until all rerun jobs complete, leaving the UI stuck in an outdated state. To trigger status updates promptly, we must use "Rerun all jobs". With this change, each job queries the previous attempt using the GitHub CLI and exits early if it already succeeded, saving time and resources while still updating commit status immediately. Signed-off-by: Nikolay Martyanov <[email protected]>
OhmSpectator
force-pushed
the
feature/self-made-rerun
branch
from
39fc0b5 to
4fec9bc
Compare
OhmSpectator
changed the title
|
It works, tested in Renes repo! https://github.com/rene/eden/actions/runs/16491015929?pr=2 |
uncleDecart
reviewed
Jul 24, 2025
| @@ -145,19 +200,44 @@ jobs: | |||
| echo "Public IP Address of the runner:" | |||
| curl -s https://api.ipify.org | |||
| shell: bash | |||
| - name: Check job status from previous attempt | |||
| id: prev_attempt | |||
There was a problem hiding this comment.
Is it possible to make it as a reusable action under eden so that we don't have to duplicate code?
There was a problem hiding this comment.
It should be a reusable step... Maybe we can make it, but I did not try. I'll take a look
uncleDecart
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce logic to skip Eden jobs that have already succeeded by checking the status of the same job in a previous workflow attempt using the GitHub Actions API. This makes it safe and efficient to use the "Rerun all jobs" button without re-running jobs that have already passed.
We currently report commit status manually in a parent workflow that depends on this one. When "Rerun failed jobs" is used, GitHub delays the execution of the status-reporting step until all re-executed jobs complete. This results in a stale and misleading UI until the rerun finishes.
To force GitHub to immediately update the status, we must use "Rerun all jobs". This change ensures that even when we rerun everything, previously successful jobs detect their prior result and exit early, saving time and compute while still enabling timely status updates.
Each job uses its name and matrix context to query its conclusion from the previous attempt via the GitHub CLI (gh api). If the job was already successful, it exits without running the test again. This logic ensures consistent job naming and reliable detection across reruns.