-
Notifications
You must be signed in to change notification settings - Fork 14
Expand Cluster Config to clarify modes and introduce tie breaker #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
07c19f2
to
8d806c6
Compare
Resolved yetus issue in latest push |
8d806c6
to
a3e06af
Compare
a3e06af
to
c930512
Compare
Rebased on latest main |
@naiming-zededa @eriknordmark @xyuria-zededa @zedi-pramodh Can I have some reviews on this PR? |
Also tagging others @rene @OhmSpectator for quick review to proceed with implementation. |
c930512
to
1c26cea
Compare
@zedi-pramodh Requested changes are in the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Existing API was limiting in declaring cluster modes. Signed-off-by: Andrew Durbin <[email protected]>
make proto-container Signed-off-by: Andrew Durbin <[email protected]>
1c26cea
to
902f890
Compare
yetus failed but the summary didn't show anything. Looks like bufcompat had an issue, maybe I need to rebase.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I don't know why the yetus summary doesn't appear, but it is failing due to where buflint results are: Ignoring that known failure, but I don't know if it causes buflint to fail to run hence not check anything else! |
Existing API was limiting in declaring cluster modes.
Introduce new cluster type 'tie_breaker'.