Skip to content

Conversation

andrewd-zededa
Copy link
Contributor

Existing API was limiting in declaring cluster modes.

Introduce new cluster type 'tie_breaker'.

@andrewd-zededa
Copy link
Contributor Author

Resolved yetus issue in latest push

@andrewd-zededa
Copy link
Contributor Author

Rebased on latest main

@andrewd-zededa
Copy link
Contributor Author

@naiming-zededa @eriknordmark @xyuria-zededa @zedi-pramodh Can I have some reviews on this PR?

@zedi-pramodh
Copy link

Also tagging others @rene @OhmSpectator for quick review to proceed with implementation.

@andrewd-zededa
Copy link
Contributor Author

@zedi-pramodh Requested changes are in the latest push

Copy link

@zedi-pramodh zedi-pramodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Existing API was limiting in declaring cluster modes.

Signed-off-by: Andrew Durbin <[email protected]>
make proto-container

Signed-off-by: Andrew Durbin <[email protected]>
@andrewd-zededa
Copy link
Contributor Author

yetus failed but the summary didn't show anything. Looks like bufcompat had an issue, maybe I need to rebase.

-1 bufcompat 0m 0s /branch-bufcompat-stderr.txt Error running buf. Please check buf stderr files.

cat branch-bufcompat-stderr.txt
register/register.proto:11:8:validate/validate.proto: does not exist

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eriknordmark
Copy link
Contributor

I don't know why the yetus summary doesn't appear, but it is failing due to
-1 overall
Vote Subsystem Runtime Log Comment
Prechecks
+1 dupname 0m 0s No case conflicting files found.
main Compile Tests
-1 bufcompat 0m 0s /branch-bufcompat-stderr.txt Error running buf. Please check buf stderr files.
Patch Compile Tests
+1 codespell 0m 0s No new issues.
+1 detsecrets 0m 12s No new issues.
+1 blanks 0m 0s The patch has no blanks issues.
+1 buflint 0m 0s No new issues.
Other Tests
0m 14s
Subsystem Report/Notes
GITHUB PR #116
Optional Tests dupname buflint bufcompat codespell detsecrets
uname Linux f562119ad57e 6.11.0-1018-azure #18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool nobuild
Personality /github/workspace/src/.yetus/personality.sh
git revision main / 902f890
modules C: . U: .
versions git=2.25.1 buf=1.8.0 codespell=2.2.1 detsecrets=1.2.0
Powered by Apache Yetus 0.14.1 https://yetus.apache.org
This message was automatically generated.

where buflint results are:
proto/register/register.proto:11:8:validate/validate.proto: does not exist

Ignoring that known failure, but I don't know if it causes buflint to fail to run hence not check anything else!

@eriknordmark eriknordmark merged commit f7ec45a into lf-edge:main Sep 22, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants