Skip to content

Updated known-good tests and npm audit fixes #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 19, 2025
Merged

Updated known-good tests and npm audit fixes #187

merged 3 commits into from
Jul 19, 2025

Conversation

lhstrh
Copy link
Member

@lhstrh lhstrh commented Jul 17, 2025

No description provided.

@lhstrh lhstrh requested a review from edwardalee July 17, 2025 22:22
@lhstrh
Copy link
Member Author

lhstrh commented Jul 17, 2025

Looks like there is an issue with the test that checks whether we correctly handle outdated versions of the pylint dependency. Not sure what's the problem though -- it could be an issue of the CI environment being configured differently. Maybe @petervdonovan has an idea?

@lhstrh lhstrh requested a review from petervdonovan July 17, 2025 22:42
Copy link
Contributor

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me, but there are still test failures.

@edwardalee
Copy link
Contributor

Do we really need the test-dependencies-outdated test? It seems to be trying to download a very old version of pylint. The name of this test suggests the test itself is outdated.

@lhstrh
Copy link
Member Author

lhstrh commented Jul 18, 2025

The test addresses the scenario where the user has an outdated version of pylint installed. This is a different situation compared to the one where the user doesn't have it installed at all. Hence the separate test. The test itself is not outdated.

@petervdonovan
Copy link
Contributor

petervdonovan commented Jul 18, 2025

I agree with Marten's explanation. The only thing I have to add is that according to the test framework, the expected update or install function is not being called in response to pylint being out of date.

This can happen if the CI environment has changed in such a way that pylint is not being brought out of date successfully by the "downgrade dependencies" step. For example, this could be because Ubuntu no longer allows managing global (outside a virtual environment) dependencies using pip.

Unfortunately I am not currently available to look into this in more detail.

@edwardalee
Copy link
Contributor

Any suggestion for fixing it? Otherwise, I'm inclined to delete the test.

@edwardalee edwardalee merged commit fe67d55 into main Jul 19, 2025
9 checks passed
@edwardalee edwardalee deleted the updates branch July 19, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants