-
Notifications
You must be signed in to change notification settings - Fork 461
Add safe-containers, merging in a single docker image, improving the onboarding workflow #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CJavierSaldana
wants to merge
11
commits into
lharries:main
Choose a base branch
from
PahVenture:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,012
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a configurable data directory with a default value of "/data", which can be overridden by the DATA_DIR environment variable. - Updated the message store initialization to create the database directory within the specified data directory. - Modified media download logic to reference the new data directory structure. - Changed the REST server to listen on localhost (127.0.0.1) for security purposes. - Updated the WhatsApp MCP server to use the new database path and ensure API calls point to the internal localhost address.
…rding Refactor data handling and add WhatsApp connection management
… div, update styling and JavaScript logic accordingly.
Maybe it would be good to create ffmpeg and nonffmpeg docker images ? |
tanmay-pathak
approved these changes
Apr 16, 2025
I guess that can be added after the merge. that could be a additional feature. I guess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes various changes to enhance the development environment, build process, and deployment workflows. The most significant changes involve adding a Docker-based setup, configuring GitHub Actions for CI/CD, and updating the Go and Python application code.
Development Environment Setup:
.devcontainer/devcontainer.json
: Added a configuration file for a development container with Go and Docker features..dockerignore
: Added a.dockerignore
file to exclude unnecessary files from Docker builds.CI/CD Workflows:
.github/workflows/docker-build.yml
: Added a GitHub Actions workflow to build and push Docker images..github/workflows/static.yml
: Added a GitHub Actions workflow to deploy static content to GitHub Pages.Application Code Enhancements:
Dockerfile
: Created a multi-stage Dockerfile to build and run the Go and Python applications.whatsapp-bridge/main.go
: Modified the Go application to use a configurable data directory and added a health check endpoint. [1] [2] [3] [4] [5] [6] [7]Documentation Updates:
README.md
: Updated the README to include Docker setup instructions and security features.These changes collectively improve the development experience, streamline the build and deployment process, and enhance the application's functionality and security.