Add error handling and fallback mechanism in AISBatchLoader #1542
+345
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented logging for batch.get() failures, triggering a sequential GET fallback. - Added error handling for cases where the batch result iterator is exhausted prematurely. - Enhanced unit tests to cover fallback scenarios, including handling of archive paths and multiple cuts. This update improves the robustness of the AISBatchLoader by ensuring that data can still be retrieved even when batch requests fail. Signed-off-by: Abhishek Gaikwad <[email protected]>
- Introduced `_get_object_from_moss_in` method to handle individual object retrieval from AIStore when batch operations fail or return empty content. - Updated the sequential GET logic to utilize the new method, improving error handling and logging for empty object scenarios. Signed-off-by: Abhishek Gaikwad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update improves the robustness of the AISBatchLoader by ensuring that data can still be retrieved even when batch requests fail.