Add compatability with new periodic notes plugin #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got started on this to have compatibility with the new Periodic Notes plugin, but turned out to be a little more work than anticipated :)
I think we're mostly there:
shouldUsePeriodicNotesSettings
toshouldUsePeriodicNotesPluginSettings
, as the argument changed fromstring
toIGranularity
, so major version number should be bumped)I have little experience with mocking interfaces, some input from you would probably be needed here.
In it's current form this pull request already fixes #24 (have tested with day planner using both legacy and new periodic notes plugin versions), but for full compatibility the other aspects should be fixed as well.
Might also solve liamcain/obsidian-calendar-plugin#307 but haven't tested, input from that side welcome as well :)