Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatability with new periodic notes plugin #32

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

burgerga
Copy link

@burgerga burgerga commented Aug 19, 2024

Got started on this to have compatibility with the new Periodic Notes plugin, but turned out to be a little more work than anticipated :)

I think we're mostly there:

  • Refactored settings.ts and and index.ts to be compatible with both 0.0.17 and >=1.0.0 (I have tried to keep the exported functions the same, but ended up changing shouldUsePeriodicNotesSettings to shouldUsePeriodicNotesPluginSettings, as the argument changed from string to IGranularity, so major version number should be bumped)
  • Just discovered there is quite a bit of settings stuff in utils.ts as well
  • tests and mocks

I have little experience with mocking interfaces, some input from you would probably be needed here.

In it's current form this pull request already fixes #24 (have tested with day planner using both legacy and new periodic notes plugin versions), but for full compatibility the other aspects should be fixed as well.

Might also solve liamcain/obsidian-calendar-plugin#307 but haven't tested, input from that side welcome as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don‘t return correct periodic notes settings after 1.0.0 ver. of periodic note
1 participant