Add transient_ex3 example demonstrating explicit DG/FV formulation of 2D advection equation #4073
+3,388
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failure in the "Test MOOSE ARM mac" recipe: is unrelated to this new example. |
roystgnr
approved these changes
Feb 11, 2025
Comment on lines
23
to
29
| // Allocate NumericVectors in _Fh. I could not figure out | ||
| // how to do this in the initialization list, I don't think it's | ||
| // possible. | ||
| // TODO: the number of problem dimensions is hard-coded here, we should | ||
| // make this depend on the input file parameters instead. | ||
| for (unsigned int i=0; i<2; ++i) | ||
| _Fh.push_back(NumericVector<Number>::build(es.comm())); |
There was a problem hiding this comment.
Would it make sense to postpone this until init_data()?
Comment on lines
485
to
490
| FEInterface::inverse_map( | ||
| elem->dim(), | ||
| fe_type, | ||
| neighbor, | ||
| qface_points, | ||
| qface_neighbor_points); |
There was a problem hiding this comment.
Could we switch this to FEMap::inverse_map(), in preparation for #4074?
Comment on lines
655
to
660
| FEInterface::inverse_map( | ||
| elem->dim(), | ||
| fe_type, | ||
| neighbor, | ||
| qface_points, | ||
| qface_neighbor_points); |
There was a problem hiding this comment.
Likewise for FEMap::inverse_map here
|
The MOOSE compilation failures here are due to idaholab/moose@08c5990, and don't have anything to do with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example is based on code originally written by @dknez for a class on numerical methods. We do have a DG example (misc_ex5) but it is for an elliptic equation and may or may not support "finite volume" mode (i.e. running with
(CONSTANT, MONOMIAL)FEs), but the present example does allow this. This example also lets us demonstrate one way of implementing an explicit timestepping discretization in libmesh, which I'm not sure we have currently. The example runs very fast and gives consistent output for me in both serial and parallel, so it will not add appreciably to test times and shouldn't give us a bunch of test failures.