Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix user variables in CMake configure scripts #771

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Prefix user variables in CMake configure scripts #771

wants to merge 1 commit into from

Conversation

thilinarmtb
Copy link
Collaborator

@thilinarmtb thilinarmtb commented Oct 30, 2024 •
edited
Loading

Description

Probably it is a good idea to prefix the variables used in the configure CMake
scripts as these could be called from other bash scripts. This PR makes calling
configure scripts similar to the following:

export OCCA_BUILD_DIR=`pwd`/build
export OCCA_INSTALL_DIR=`pwd`/install
./configure-cmake.sh

instead of the following:

export BUILD_DIR=`pwd`/build
export INSTALL_DIR=`pwd`/install
./configure-cmake.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thilinarmtb