fix: identify: push should not dial a new connection

libp2p · Nov 12, 2024 · 915400e · 915400e
1 parent 3ba2089
commit 915400e
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/p2p/protocol/identify/id.go b/p2p/protocol/identify/id.go
@@ -347,6 +347,10 @@ func (ids *idService) sendPushes(ctx context.Context) {
 			defer func() { <-sem }()
 			ctx, cancel := context.WithTimeout(ctx, 5*time.Second)
 			defer cancel()
+
+			// We only want to send an identify push if we already have an open
+			// connection.
+			ctx = network.WithNoDial(ctx, "id push")
 			str, err := ids.Host.NewStream(ctx, c.RemotePeer(), IDPush)
 			if err != nil { // connection might have been closed recently
 				return