swarm: bugfix: don't open new stream over transient connection #2450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
force-pushed
the
sukun/fix-transient
branch
from
29755ab
to
d3d6419
Compare
marten-seemann
approved these changes
Aug 3, 2023
marten-seemann
pushed a commit
that referenced
this pull request
Aug 3, 2023
marten-seemann
pushed a commit
that referenced
this pull request
Aug 3, 2023
marten-seemann
pushed a commit
that referenced
this pull request
Aug 3, 2023
marten-seemann
pushed a commit
that referenced
this pull request
Aug 3, 2023
marten-seemann
pushed a commit
that referenced
this pull request
Aug 3, 2023
marten-seemann
pushed a commit
that referenced
this pull request
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #1603
We should not rely on type assertion here for this work. Ideally we should move Transient field to
network.ConnectionStatewhich is supported bytransport.CapableConn. I'll do that in a later PR.