Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.36.3 #2945

Closed
wants to merge 13 commits into from
Closed

Release v0.36.3 #2945

wants to merge 13 commits into from

Conversation

sukunrt
Copy link
Member

@sukunrt sukunrt commented Aug 30, 2024

Same as master except

  • Make BlackHoleState type public 99433a2

joshklop and others added 13 commits August 19, 2024 10:32
* Add failing proto test

* Add a new proto compilation script

A proto file's *import path* is relative to one of the `--proto-path`s.

Previously, the proto files were compiled separately. Some invocations
used different values for the `--proto_path`, which led to inconsistent
import paths in proto file descriptors.

Typically, this wouldn't be a problem. However, if a downstream project
uses `protoregistry.GlobalFiles` to inspect proto dependencies, it will fail
to find a dependency's file descriptor when the dependency was compiled
with a different `--proto_path`.

By using a single script to generate all protobuf files, we can ensure
the `--proto_path` is always set to the same sane value (the root of the
project, as suggested in the [official documentation]).

[official documentation]: https://protobuf.dev/programming-guides/proto2/#importing

* Add go_package options so scripts/gen-proto.sh succeeds

* Remove undesirable `go:generate protoc` directives

* Run `go generate ./...`

* Script uses arrays, I think we need bash

---------

Co-authored-by: Marco Munizaga <[email protected]>
* Lint fixes

* Use latest go version for go-check

Fixes nil pointer issue in staticcheck

* Add test_analysis helper script

* Use custom go-test-template

* Add some tests to the test_analysis script

* Always upload test_results db

* Attempt to fix test on windows

* Better if statement

* Try to fix flaky test

* Disable caching setup-go on Windows

* Better if statement

* Tweak

* Always upload summary and artifact

* Close db

* No extra newline
* chore: bump go.mod to Go 1.22 and run go fix

* Bump docker builder version

---------

Co-authored-by: Marco Munizaga <[email protected]>
* fix: allow punching undialable host public ip

fixes #2913

* chore: use interface listen addrs to enable dctur

* fix: filter public addresses

* chore: remove unused function

* chore: formatting

---------

Co-authored-by: Daniel N <[email protected]>
@sukunrt sukunrt requested a review from MarcoPolo August 30, 2024 15:10
@sukunrt sukunrt changed the base branch from master to release-v036 August 30, 2024 15:10
@sukunrt sukunrt closed this Aug 30, 2024
Copy link

Suggested version: 0.36.3

Comparing to: v0.36.2 (diff)

Changes in configuration file(s):

diff --git a/go.mod b/go.mod
index 6359d180d..684f35442 100644
--- a/go.mod
+++ b/go.mod
@@ -1,6 +1,6 @@
 module github.com/libp2p/go-libp2p
 
-go 1.21
+go 1.22
 
 retract v0.26.1 // Tag was applied incorrectly due to a bug in the release workflow.
 diff --git a/examples/go.mod b/examples/go.mod
index 578546a87..e4ba49831 100644
--- a/examples/go.mod
+++ b/examples/go.mod
@@ -1,6 +1,6 @@
 module github.com/libp2p/go-libp2p/examples
 
-go 1.21
+go 1.22
 
 require (
 	github.com/gogo/protobuf v1.3.2
diff --git a/examples/ipfs-camp-2019/go.mod b/examples/ipfs-camp-2019/go.mod
index 0d0b29c02..268135aba 100644
--- a/examples/ipfs-camp-2019/go.mod
+++ b/examples/ipfs-camp-2019/go.mod
@@ -1,6 +1,6 @@
 module github.com/libp2p/go-libp2p/examples/ipfs-camp-2019
 
-go 1.21
+go 1.22
 
 require (
 	github.com/gogo/protobuf v1.3.2
diff --git a/examples/pubsub/basic-chat-with-rendezvous/go.mod b/examples/pubsub/basic-chat-with-rendezvous/go.mod
index cd90b4d5f..c45d19866 100644
--- a/examples/pubsub/basic-chat-with-rendezvous/go.mod
+++ b/examples/pubsub/basic-chat-with-rendezvous/go.mod
@@ -1,6 +1,6 @@
 module github.com/libp2p/go-libp2p/examples/pubsub/chat
 
-go 1.21
+go 1.22
 
 require (
 	github.com/libp2p/go-libp2p v0.33.0
diff --git a/examples/pubsub/chat/go.mod b/examples/pubsub/chat/go.mod
index 6c53916bb..3f1e6c2f0 100644
--- a/examples/pubsub/chat/go.mod
+++ b/examples/pubsub/chat/go.mod
@@ -1,6 +1,6 @@
 module github.com/libp2p/go-libp2p/examples/pubsub/chat
 
-go 1.21
+go 1.22
 
 require (
 	github.com/gdamore/tcell/v2 v2.5.2
diff --git a/scripts/test_analysis/go.mod b/scripts/test_analysis/go.mod
new file mode 100644
index 000000000..84ffc92b3
--- /dev/null
+++ b/scripts/test_analysis/go.mod
@@ -0,0 +1,17 @@
+module github.com/libp2p/go-libp2p/scripts/test_analysis
+
+go 1.22
+
+require github.com/glebarez/go-sqlite v1.22.0
+
+require (
+	github.com/dustin/go-humanize v1.0.1 // indirect
+	github.com/google/uuid v1.5.0 // indirect
+	github.com/mattn/go-isatty v0.0.20 // indirect
+	github.com/remyoudompheng/bigfft v0.0.0-20230129092748-24d4a6f8daec // indirect
+	golang.org/x/sys v0.15.0 // indirect
+	modernc.org/libc v1.37.6 // indirect
+	modernc.org/mathutil v1.6.0 // indirect
+	modernc.org/memory v1.7.2 // indirect
+	modernc.org/sqlite v1.28.0 // indirect
+)
diff --git a/test-plans/go.mod b/test-plans/go.mod
index e963be7bb..466a55e91 100644
--- a/test-plans/go.mod
+++ b/test-plans/go.mod
@@ -1,6 +1,6 @@
 module github.com/libp2p/go-libp2p/test-plans/m/v2
 
-go 1.21
+go 1.22
 
 require (
 	github.com/go-redis/redis/v8 v8.11.5

gorelease says:

# github.com/libp2p/go-libp2p/p2p/protocol/circuitv2
## incompatible changes
package removed

# diagnostics
go.mod: the following requirements are needed
	github.com/cheekybits/[email protected]
	github.com/fsnotify/[email protected]
	github.com/go-task/[email protected]
	github.com/golang/[email protected]
	github.com/hashicorp/[email protected]
	github.com/libp2p/[email protected]
	github.com/libp2p/go-yamux/[email protected]
	github.com/lucas-clemente/[email protected]
	github.com/marten-seemann/[email protected]
	github.com/marten-seemann/[email protected]
	github.com/marten-seemann/[email protected]
	github.com/marten-seemann/[email protected]
	github.com/mattn/[email protected]
	github.com/onsi/[email protected]
	github.com/spacemonkeygo/[email protected]
	[email protected]
	gopkg.in/[email protected]
Run 'go mod tidy' to add missing requirements.
required module github.com/microcosm-cc/[email protected] retracted by module author: Retract older versions as only latest is to be depended upon

# summary
Suggested version: v0.37.0

gocompat says:

HEAD is now at a0349afb8 Release v0.36.2
Previous HEAD position was a0349afb8 Release v0.36.2
Switched to branch 'master'
Your branch is up to date with 'origin/master'.

Cutting a Release (and modifying non-markdown files)

This PR is modifying both version.json and non-markdown files.
The Release Checker is not able to analyse files that are not checked in to master. This might cause the above analysis to be inaccurate.
Please consider performing all the code changes in a separate PR before cutting the release.

Automatically created GitHub Release

A draft GitHub Release has been created.
It is going to be published when this PR is merged.
You can modify its' body to include any release notes you wish to include with the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants