-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Feat/memory transport #3022
base: master
Are you sure you want to change the base?
Conversation
Friendly reminder to test your transport by adding a case here:
|
Thanks, will add it. Could you possibly take a look at this PR multiformats/go-multiaddr#256 ? Edit: This is the issue I'm currently having while running my tests
|
I have few questions:
|
I think io.Pipe is fine. This transport will only be used for tests, so it's nice to get as much of the work done by the stdlib as we can. |
Closes #2293