rcmgr: update connLimiter network prefix limits from peer-specific al… #3335
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Fixes #3238
Problem
When using
WithAllowlistedMultiaddrswith peer-specific multiaddrs (e.g./ip4/1.2.3.0/ipcidr/24/p2p/QmPeer), the network prefix was not being added to the connection limiter. This meant users had to use bothWithAllowlistedMultiaddrsandWithNetworkPrefixLimitto achieve the desired effect.Solution
Updated the resource manager initialization to check both
allowlist.allowedNetworksandallowlist.allowedPeerByNetworkwhen setting up connection limiter network prefix limits. This ensures that any network prefixes specified in peer-specific allowlist entries are also added to the connection limiter.Changes
allowlist.allowedPeerByNetworkand add any network prefixes to the connection limiterGetAllowlistedSystemLimits()for consistencyTesting
Added a new test case "IPv4 with peer ID" that verifies: