fix: remove duplicate listen addresses to avoid muxer panic#3347
Open
derrandz wants to merge 1 commit intolibp2p:masterfrom
Open
fix: remove duplicate listen addresses to avoid muxer panic#3347derrandz wants to merge 1 commit intolibp2p:masterfrom
derrandz wants to merge 1 commit intolibp2p:masterfrom
Conversation
Collaborator
|
It is an error to try to Listen on the same address twice. This is probably not what you want. |
Author
|
hmmmm, what should we do when passed two identical listen addresses? that muxer panic is very ambiguous. maybe we should handle this case? passing two addresses is a user bug ofc but it was disorientating enough to see that panic |
Collaborator
|
a better error would be a welcome change |
derrandz
changed the title
Author
|
@MarcoPolo I went with a solution to simply ignore and discard duplicate listen addresses. Wdyt? or shall we return an error on validate? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes this part of the issue: #3340 (comment)