swapped dep to maintained package #896
Conversation
|
Thanks for the PR @TJKoury |
|
@TJKoury it seems that a release of |
|
@vasco-santos Is there a task for running these typescript checks locally? Also, what is aegir checking for the bundle size? |
This github action to control no big increases in bundle size for the browser over time |
|
That’s strange, I’ve run the build task a few times but no errors. |
I could replicate locally. Perhaps you need to remove package-lock and reinstall. Anyway, I already fixed that in #897 but I am seeing other new issues now |
|
Copy. Let me get to where you are and I can help tackle the other issues.
I’ll be good to go after a few iterations here.
…On Tue, Mar 9, 2021 at 9:00 AM Vasco Santos ***@***.***> wrote:
That’s strange, I’ve run the build task a few times but no errors.
I could replicate locally. Perhaps you need to remove package-lock and
reinstall. Anyway, I already fixed that in #897
<#897> but I am seeing other new
issues now
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#896 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFW4KCKFXEF73S5PEPCFI3TCYSYDANCNFSM4Y2OXOGA>
.
|
…b.com:libp2p/js-libp2p into promisify-es6
Fixes a regression introduced by #896 `promisify-es6` was swapped for `es6-promisify` but the APIs of the two modules are no the same so the NAT hole punching code broke. Also changes port numbers to 0 in the tests as other processes can be listening on those ports which causes spurious test failures.
Solves this issue.
Went with a different library (es6-promisify) since the package maintainer's solution (use Node's native util.promisify) would require an additional shim for browser use.