Implement cli tool to handle key material

[demfabris]

So for decoding, if I understood correctly we are reading from a IPFS config file passed as argument.
Do we check for this file under IPFS_PATH as well?

For encoding are we reusing this implementation: peer-id-generator ?

@mxinden
Refs: #482

[mxinden]

Thanks for following up here @fabricio7p!

Do we check for this file under IPFS_PATH as well?

I would require passing a config file path for now. I would argue that libp2p shouldn't depend on IPFS concepts much. While we would depend on their file-format, at least we wouldn't depend on their filesystem conventions or environment variables. Does that make sense?

For encoding are we reusing this implementation: peer-id-generator ?

Something along those lines. In my eyes, by default it should just generate a random identity. The feature of choosing a custom prefix should be a nice-to-have.

[mxinden]

I think the ipfs key XXX subcommand is a good guiding example (thanks @lidel for the pointer). No need to thrive for feature parity though. The rust-libp2p client should be a lot more minimalist and without the IPFS related concepts (IPNS).

[demfabris]

I think the ipfs key XXX subcommand is a good guiding example (thanks @lidel for the pointer). No need to thrive for feature parity though. The rust-libp2p client should be a lot more minimalist and without the IPFS related concepts (IPNS).

Sure thing, I'll post updates soon.
Thanks for the investigation

[demfabris]

I choose to use argh to be way way lighter than clap/structopt.
Did a couple of changes to your peer-id-generator logic because it was hanging on my PC, check review

cli api

# Gen random key material, with prefix at your option
keygen rand [--prefix <prefix>]

# Gen key material from IPFS config
keygen from --config <path>

[mxinden]

Great. Thanks for the work here!

I choose to use argh to be way way lighter than clap/structopt

We use structopt in all other examples across the project. I don't really have a strong opinion on which one to use, but as a maintainer I would prefer being consistent.

Unless you feel strongly about it, I would prefer if this one would use structopt as well.

[demfabris]

Added --json flag to output json formatted. Exactly the way it's on the IPFS config file
Using structopt

[mxinden]

3 more comments. Otherwise this is good to go. Thanks for the new tool!

[demfabris]

All points addressed 👍🏻

ready to go?

[mxinden]

Looks good to me. Thanks @demfabris. This tool will be helpful going forward.

[mxinden]

Unrelated test failure:

---- test_dial_error stdout ----
thread 'test_dial_error' panicked at 'Unexpected swarm event: Behaviour(InboundProbe(Error { probe_id: ProbeId(0), peer: PeerId("12D3KooWL97LtsmyDtSbDxJ8675kG5Ne49hZX41y5Na7h64RXZNz"), error: Response(DialError) })).', protocols/autonat/tests/test_server.rs:257:26
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

https://github.com/libp2p/rust-libp2p/runs/5510014225?check_suite_focus=true

//CC @elenaf9