Skip to content

Conversation

qiangzhao
Copy link

Hi @epico:
I found that currently ibus-libpinyin setup don't response for compile options, (eg: --disable-lua-extension, --disable-english-input-mode). What ever they are enabled or not they will show in the user data frame:
build_option_result
So I change the configure.ac, setup/config.h.in to pass these values to ibus-libpinyin setup;

While ibus-libpinyin setup use grid to GtkGrid to show these check buttons, so when I try to hide related button, there will have one or more blanks in the grid:
grid_hide_result
So I change the main2.py to dynamically attach buttons to the grid to make display more clean and tidy

Modifiedsetup/Makefile.am a little: Make it could drop generated config.py when make clean :-)

With the respect of your great previous work, other places are the same as before.

Please take a review when you have time. Thank you so much!

@qiangzhao
Copy link
Author

Hi epico:
The modification has been updated as the offline communication.
Please re-review. Welcome for your valuable suggestions!

@qiangzhao
Copy link
Author

Hi epico:
The __frame_user_table already rollback to the original request edition.
Any modification comments are welcome!

@qiangzhao qiangzhao force-pushed the main branch 2 times, most recently from b2146d0 to 9a286a3 Compare August 25, 2025 07:25
@epico epico merged commit 619f0d6 into libpinyin:main Aug 25, 2025
1 check passed
@epico
Copy link
Member

epico commented Aug 25, 2025

Thanks for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants