fix: Fix keyboard hotkeys not working #7975
Conversation
Bnyro
left a comment
Bnyro
left a comment
There was a problem hiding this comment.
For me, keyboard events already work fine, so I don't see why these changes are needed?
| binding.player.apply { | ||
| isFocusable = true | ||
| isFocusableInTouchMode = true | ||
| requestFocus() | ||
| setOnKeyListener { _, keyCode, _ -> | ||
| onKeyUp(keyCode) | ||
| } | ||
| } |
There was a problem hiding this comment.
In any case, this should be moved to CustomExoPlayerView.kt
On my and my wifes tablet (Lenovo Pro Tab 11 and Lenovo Pro Tab 12 respectivaly) is a hit or miss. Sometimes it pauses the video on the first try, then the focus automatically changes to a random element on screen without me tapping anywhere. So if I press spacebar again to resume the video most of the time it exits fullscreen and or plays the next video. |
Thanks for the explanation! (I'm not really using LibreTube with a keyboard, so I can't tell how it performs in the real world except from a short test) In that case it definitely makes sense to include these changes. It'd be great if you could move the changes you made to the |
3 participants
This commit fixes tablets with attached keyboard not registering input