fix start serverIdx in pingList when some servers are down #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Wouldn't the following for loop do the same thing? |
muzikr
added a commit
to muzikr/packages
that referenced
this pull request
Nov 10, 2025
If the server is down it can still be selected to test on it. This fixes the bug. See: - librespeed/speedtest-cli#94
muzikr
added a commit
to muzikr/packages
that referenced
this pull request
Nov 11, 2025
If the server is down it can still be selected to test on it. This fixes the bug. See: - librespeed/speedtest-cli#94 Signed-off-by: Richard Muzik <[email protected]>
muzikr
added a commit
to muzikr/packages
that referenced
this pull request
Nov 11, 2025
If the server is down it can still be selected to test on it. This fixes the bug. See: - librespeed/speedtest-cli#94 Signed-off-by: Richard Muzik <[email protected]>
Merged
4 tasks
muzikr
added a commit
to muzikr/packages
that referenced
this pull request
Nov 11, 2025
If the server is down it can still be selected to test on it. This fixes the bug. See: - librespeed/speedtest-cli#94 Signed-off-by: Richard Muzik <[email protected]>
muzikr
added a commit
to muzikr/packages
that referenced
this pull request
Nov 11, 2025
If the server is down it can still be selected to test on it. This fixes the bug. See: - librespeed/speedtest-cli#94 Signed-off-by: Richard Muzik <[email protected]>
BKPepe
pushed a commit
to openwrt/packages
that referenced
this pull request
Nov 11, 2025
If the server is down it can still be selected to test on it. This fixes the bug. See: - librespeed/speedtest-cli#94 Signed-off-by: Richard Muzik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug: as below json example, when first server in config file is down/not exist/error, the selected idx will be 0, the correct index should be 1.
json example:
[ { "id": 2, "name": "noexist", "server": "http://not.exist:8989", "dlURL": "garbage.php", "ulURL": "empty.php", "pingURL": "empty.php", "getIpURL": "getIP.php" }, { "id": 3, "name": "good", "server": "http://good.server:8989", "dlURL": "garbage.php", "ulURL": "empty.php", "pingURL": "empty.php", "getIpURL": "getIP.php" } ]