Fix initialization of conf for stats #62
Open
+49
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Unintentionally pushed a different change to same branch. Let me know if need to recreate PR with just the original change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Even though I set statistics_password in my config (which is
/etc/speedtest-settings.toml), I got the message 'Please set statistics_password in settings.toml to enable access'.Root cause
In stats.go, global var
confis initialized even before main is called. At this time configFile is empty as it is not set yet. If the config path is not explicitly set using-cflag, viper initializes fromsettings.tomlin current folder. If nosettings.tomlfiles is found,confis initialized with default values and thus does not use the password set in config file.