Skip to content

removes homething devicetype #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 3, 2025
Merged

removes homething devicetype #1471

merged 2 commits into from
Mar 3, 2025

Conversation

cz8s
Copy link
Contributor

@cz8s cz8s commented Feb 25, 2025

fixes #1470

@cz8s
Copy link
Contributor Author

cz8s commented Feb 25, 2025

This will break installations that use "homething" as devicetype:

~/code/librespot » ./target/debug/librespot --device-type=homething                                                                                   
[2025-02-25T17:22:35Z INFO  librespot] librespot 0.6.0-dev 7639c55 (Built on 2025-02-25, Build ID: UQRTxkvc, Profile: debug)
[2025-02-25T17:22:35Z ERROR librespot] Invalid `--device-type` / `-F`: "homething"
Valid `--device-type` / `-F` values: computer, tablet, smartphone, speaker, tv, avr, stb, audiodongle, gameconsole, castaudio, castvideo, automobile, smartwatch, chromebook, carthing
Default: Speaker

@cz8s cz8s mentioned this pull request Feb 25, 2025
Closed
photovoltex
photovoltex requested changes Feb 25, 2025
View reviewed changes
Copy link
Member

@photovoltex photovoltex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Besides the modfied protobuf it looks good so far^^. Also, please add an entry in the CHANGELOG.md that reflects the change :)

cz8s added 2 commits February 25, 2025 20:15
@cz8s
removes homething devicetype
0c6c77d 
fixes librespot-org#1470

From the comments about "homething" support in spotify:
"Did they ever release their homething product? I assumed not and guess they removed all support for it. We could just remove this footgun."
@cz8s
mention breaking homething change in Changelog
c97f4bc
@cz8s cz8s force-pushed the remove_homething_devicetype branch from 7639c55 to c97f4bc Compare February 25, 2025 19:35
photovoltex
photovoltex previously approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@photovoltex photovoltex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick adjustments :)

photovoltex
photovoltex reviewed Feb 25, 2025
View reviewed changes
@cz8s cz8s force-pushed the remove_homething_devicetype branch from bee3a36 to c97f4bc Compare February 26, 2025 07:10
@photovoltex photovoltex merged commit 11c3df8 into librespot-org:dev Mar 3, 2025
26 checks passed
@photovoltex
Copy link
Member

Sorry for the late merge. I usually want to keep the PR open for around a day after approving, so that others have the change to provide some comment if they want to. But I kinda got distracted and forgot to merge it^^;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@photovoltex photovoltex photovoltex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DeviceType "homething" crashes spotify on android
2 participants
@cz8s @photovoltex