Saturate seek position to track duration

[roderickvd]

The fix prevents seeking past the end of a track by capping the requested seek position to the actual duration. It also makes timestamp calculation more robust.

This does not entirely fix #1472, but does make the decoder more robust against invalid calls.

Please test this for me, because I no longer have a Spotify account.

[Copilot]

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

playback/src/player.rs:1783

• Changing the match from 'PlayerState::Invalid { .. }' to 'PlayerState::Invalid' may fail to match variants that carry additional data. Confirm that the state does not need to account for inner fields for proper error handling.

if matches!(self.state, PlayerState::Invalid) {

playback/src/decoder/symphonia_decoder.rs:137

• [nitpick] The conversion to Duration and subsequent use of as_millis may change the rounding behavior compared to the original calculation. Verify that truncating sub-millisecond precision is acceptable for timestamp accuracy.

let time = Duration::from(time_base.calc_time(ts));

[roderickvd]

P.S. testing also means just doing some random seeks, to verify there is no regression in the normal case.

[photovoltex]

Thanks for the improved handling :)

Just some minor thoughts to the conversion handling^^