spirc: Configurable volume control steps #1498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the volume control steps to be configured via the `--volume-steps` command line parameter. The author personally found the default volume steps of `1024` to be completely unusable, and is presently using `128` as his configuration. Perhaps consider this as a more reasonable default. Additionally, reduce the delay in volume update from a wopping two seconds to 500ms, again for usability. Also clean up the seemingly unnecessary use of a pattern match on whether or not `--initial-volume` was supplied.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a configurable volume control step parameter while also reducing the volume update delay for improved usability, and it refines the handling of the initial volume option.
- Adds the new --volume-steps option and its associated description and parsing logic.
- Reduces the volume update delay in the spirc module from 2 seconds to 500ms.
- Simplifies the branching for initial volume handling by eliminating an unnecessary pattern match.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main.rs | Introduces --volume-steps option and streamlines initial volume handling. |
| connect/src/spirc.rs | Reduces volume update delay from 2s to 500ms. |
photovoltex
reviewed
Apr 29, 2025
photovoltex
reviewed
May 1, 2025
photovoltex
reviewed
May 1, 2025
|
If you merge this, make sure it is a squash merge you don't want those fixup commits lingering. Otherwise I can squash them together into a single commit and merge that. |
|
I will just link to what was said in this #1495 (comment). But yeah no worries, will do :) |
photovoltex
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the volume control steps to be configured via the
--volume-stepscommand line parameter. The author personally found the default volume steps of1024to be completely unusable, and is presently using128as his configuration. Updated the default to64which more closely mirrors the official client behavior.Additionally, reduce the delay in volume update from a wopping two seconds to 500ms, again for usability.
Also clean up the seemingly unnecessary use of a pattern match on whether or not
--initial-volumewas supplied.