Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ozone theme: mei #15394

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ozone theme: mei #15394

wants to merge 1 commit into from
+87 −1

Conversation

fpscan
Copy link
Contributor

@fpscan fpscan commented Jun 18, 2023

@RobLoach
Copy link
Member

RobLoach commented Jul 15, 2023 •
edited
Loading

Is it just me, or does this hurt my eyes?

Active background color: 249,0,0
Foreground color: 255,245,245

Contrast between them is a bit low? Possibly make the #f90000 a bit darker so that it's further away from the white. Check against a contract checker like https://webaim.org/resources/contrastchecker/

Screenshot at 2023-07-15 15-32-28

@fpscan
Copy link
Contributor Author

fpscan commented Jul 28, 2023

Is it just me, or does this hurt my eyes?

Sorry, that wasn't the intention, it meant to be refer chinese new year, how about the following changes?

COLOR_HEX_TO_FLOAT(0xb30000, 1.0f),                    /* text */
COLOR_HEX_TO_FLOAT(0xc20000, 1.0f),                    /* selection */

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fpscan @RobLoach