Fullscreen refresh rate improvements #16705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle refresh rate as float in general, and add also extra attributes (interlaced, doublescan) for video modes. Make it possible to select exact mode (interlaced / doublescan modes will not be selected), and allow close matches such as 49.5 Hz for PAL 50 Hz.
|
Looks reasonable to me. |
|
Buildbot fails for msvc05: c:\gitlab-runner\builds-sukb9sf\2\libretro\retroarch\griffin../gfx/display_servers/dispserv_win32.c(371) : error C2065: 'DM_INTERLACED' : undeclared identifier I'll try to find a workaround. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handle refresh rate as float in general, and add also extra attributes (interlaced, doublescan) for video modes. Possible to select exact mode (interlaced / doublescan modes will not be selected), and allow close matches such as 49.5 Hz for PAL 50 Hz.
Refresh rates will appear as float (3 decimals) in the fullscreen resolution list, if context driver allows getting the exact value (i.e. in KMS), otherwise existing display and function remains.
Related Issues
Closes #16615
Related Pull Requests
#15301
#12795
Reviewers
A quick check would be nice that refresh rate switch to 50Hz still works in case of Windows (general operation and resolution changes checked, but I it seems my old laptop cannot do 50Hz at all) - any core with PAL region should be OK.
@sonninnos for general comments