Fix replay rewind/load state bug #16710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will return 0 for non-file streams. I didn't want to mess around with memory_stream (which could in theory have a truncate impl that sets size) because there were globals and stuff and I got nervous (also truncate might *grow* a file if the new length is longer than the old one and then I'd have to think about realloc, etc).
|
Is this released? |
|
I believe the last release was June 4 so probably not? |
|
Looking forward😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, doing these actions will cause issues with replays (desync):
On playback, you'll see 1 second of holding left followed by 4 seconds of holding right, because while we seek to the replay state as of the loaded state we don't truncate the file. This patch adds
intfstream_truncateand uses it while recording to fix record-and-replay.