winmm_midi: Fix midi_write_long_event unable to send sysex correctly #16804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
negativeExponent
changed the title
negativeExponent
changed the title
negativeExponent
changed the title
negativeExponent
changed the title
|
Dword alignment makes sense, but it is not quite clear why the CI jobs would fail? |
negativeExponent
force-pushed
the
patch-3
branch
from
7cdeeb5 to
560ac87
Compare
|
must be a CI thing. should clear on a refresh |
|
I see something weird in this PR:
Perhaps an accidental renaming of the file which would explain why the CI jobs fail? |
data size has to be DWORD aligned. Fix libretro#16790 review before merge for confirmation/corrections: @LibretroAdmin @zoltanvb and others
negativeExponent
force-pushed
the
patch-3
branch
from
560ac87 to
e2f9b89
Compare
|
sorry about that.... its should be now corrected. |
|
Ah, thanks. Seems like it's good to merge now. |
Sunderland93
pushed a commit
to Sunderland93/RetroArch
that referenced
this pull request
Dec 26, 2024
…ibretro#16804) data size has to be DWORD aligned. Fix libretro#16790 review before merge for confirmation/corrections: @LibretroAdmin @zoltanvb and others
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guidelines
Description
Data size of buffer in midi_write_long_msg() has to be DWORD aligned (is that the correct term?)
Related Issues
Fix #16790
Fix libretro/px68k-libretro#164
Related Pull Requests
[Any other PRs from related repositories that might be needed for this pull request to work]
Reviewers
review before merge for confirmation/corrections:
@LibretroAdmin @zoltanvb and others