Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ozone: Messagebox background asset fix #17566

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

sonninnos
Copy link
Collaborator

@sonninnos sonninnos commented Feb 13, 2025

Description

The addition of the new "Selenium" theme in Ozone caused the help messagebox background to disappear always, because the theme defined theme asset files which still do not exist after updating assets. Therefore:

  • Set the theme asset as NULL for the time being so there is no checking
  • Modify asset checking to care only for the current theme assets instead of all
    • Required moving the themes to the same order as in menu_defines.h

Also:

  • Adjusted Ozone messagebox font and margins to match others more
  • Adjusted all menu drivers background darkening opacity depending on messagebox or osk

Current:
retroarch_2025_02_13_08_47_11_147

Asset fixed:
retroarch_2025_02_13_09_32_44_894

More margin:
retroarch_2025_02_13_09_39_14_941

Final:
retroarch_2025_02_13_10_02_06_610

And in comparison:
retroarch_2025_02_13_08_46_33_639

retroarch_2025_02_13_08_46_54_373

retroarch_2025_02_13_08_46_43_861

Perhaps also the width should be narrower in Ozone and GLUI as it is in XMB, since it is more readable.

@LibretroAdmin LibretroAdmin merged commit 01a2da4 into libretro:master Feb 13, 2025
30 checks passed
@sonninnos sonninnos deleted the ozone-messagebox-assets branch February 13, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants