Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated platform_win32.c to properly detect OS version info on Win11. #17749

Merged
merged 1 commit into from
Mar 29, 2025

Conversation

odditude42
Copy link
Contributor

Removed .vscode config files which were still cached in the index
prior to the directory being added to .gitignore.

Description

  • Updated platform_win32.c to properly detect OS version info on Win11.
    • GetVersionEx behavior has been changed in Win11, and now only reports it as Windows 8. There are a litany of helper functions which are the recommended way to check if a given feature is supported, but they are all in the vein of "is this version x or later" - which doesn't give the info we're looking for. The info can be pulled from the Registry, though.
      The new code is ifdef'ed to only run on Vista or later, and silently fails through to the existing code if the registry read doesn't work. The very first check performed won't work on 10 (and presumably earlier) and should serve as the single gate; however, for sanity's sake we pass through to the legacy code if any of the reads fail.
  • Removed .vscode config files which were still cached in the index prior to the directory being added to .gitignore.

Related Issues

#13110

Related Pull Requests

N/A

Reviewers

@sonninnos (please add other relevant reviewers!)

Removed .vscode config files which were still cached in the index
  prior to the directory being added to .gitignore.
@odditude42
Copy link
Contributor Author

Noticed a indent error on line 303, but holding any changes until someone else gets eyes on.

@LibretroAdmin LibretroAdmin merged commit a3c144d into libretro:master Mar 29, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants