allow passing HAVE_OGG_OGC to link to needed OGG libs in PPC portlibs on libOGC platforms (GameCube/Wii), needed for a few cores. #18100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, needed for a few cores.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pass the argument HAVE_OGG_OGC=1 when compiling GameCube or Wii cores that use and/or need shared OGG libraries (ex. libvorbis).
Coming from my conversation with upcoming OGG support on PicoDrive: irixxxx/picodrive#180
Works on Makefile.wii, Makefile.ngc, and Makefile.griffin.
Please take note that it will look for the libraries libvorbisfile, libvorbis, and libogg in the location /opt/devkitpro/portlibs/ppc/lib.
By default, this is disabled to avoid compilation problems caused by most people not having those libraries installed adequately.
Also please take note that some Wii cores that use libvorbis also need to modify their Makefiles to seek for the include files in /opt/devkitpro/portlibs/ppc/include.
e.g., add to CFLAGS the following: -I$(DEVKITPRO)/portlibs/ppc/include
See example: https://github.com/irixxxx/picodrive/pull/186/files#diff-9b06322f74c0fac1f20a02120275946e3e2ec8e150ef3edfd424f8ac1c345799R285
Thanks to @irixxxx for helping me with this.