[Wayland] Add support for xdg-toplevel-tag-v1 protocol#18317
Open
Sunderland93 wants to merge 10 commits intolibretro:masterfrom
Open
[Wayland] Add support for xdg-toplevel-tag-v1 protocol#18317Sunderland93 wants to merge 10 commits intolibretro:masterfrom
Sunderland93 wants to merge 10 commits intolibretro:masterfrom
Conversation
Contributor
|
It's a bit of a nitpick but I'd go for something like: xdg_toplevel_tag_manager_v1_set_toplevel_tag(
wl->xdg_toplevel_tag_manager, wl->xdg_toplevel,
WINDOW_TITLE " main window");That way it can be easier to make distinct from the qt companion window if that gets tagged in the future. Maybe renaming |
Contributor
Author
|
Yes, you're right. According to the protocol, the tag is an additional toplevel identifier, in addition to the |
Contributor
Author
|
@ColinKinloch are there any other suggestions? |
0e9988e to
bca0b66
Compare
Contributor
Author
|
@ColinKinloch @LibretroAdmin Are there any comments or objections? |
Contributor
Author
|
Ping |
ColinKinloch
suggested changes
Jan 4, 2026
ColinKinloch
approved these changes
Jan 13, 2026
Contributor
ColinKinloch
left a comment
There was a problem hiding this comment.
@LibretroAdmin LGTM
Contributor
Author
|
@LibretroAdmin ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement support for xdg-toplevel-tag-v1 protocol, which is useful for window rules (e.g. in Kwin) or restore window position and size after restart application.