Add Samba share browse and load content #18446
Open
+53,932
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guidelines
Description
Adds the ability to add act as a samba client. To do so there is new settings under System->Network->SMB Shares to specify IP address, share name, optional username and password etc.
It can connect to a single share, then the user can access that configured shared under "Load Content" to load their ROMs.
It may be needed to load the core first before all related files displayed (e.g. Quake 2 PAK do not get listed until loading core).
All tests done using a local workgroup, not tested under active directory environment. My server was Ubuntu not Windows.
All code should be protected by HAVE_SMBCLIENT so it should compile cleanly without affecting anything else if disabled.
Portable considerations:
In Makefile.common, I have set necessary CFLAGS for building smbclient.
Normally to build libsmb2 you would run cmake in deps/libsmb2/build to generate: deps/libsmb2/build/config.h, but that doesn't suit the current build system for RetroArch well
In the root of deps/libsmb2 there are makefiles targetting different platforms e.g. PS2 etc. I have not explored these as I am just targetting Linux.
Related Issues
#11773
#11518
#8653
#8173
Related Pull Requests
Reviewers