Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY] android: Update and rename Pro Controller.cfg to Nintendo Switch Pro Controller.cfg #1158

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

davidhedlund
Copy link
Contributor

@davidhedlund davidhedlund commented Aug 1, 2024

  • Updated the input variables
  • Streamlined the autoconfig file by removing comments and blank lines, sorting variables, and adding labels.
  • Older Android kernels identify the controller as "Pro Controller," whereas newer kernels recognize it as "Nintendo Switch Pro Controller," which provides a more complete name.

input_menu_toggle_btn is bound to the Capture button (Circle label) instead of the the Home button (Home label), because the Home button is bound to Android's Home button.
…r.cfg

"Nintendo Switch Pro Controller" not "Pro Controller"
@davidhedlund davidhedlund changed the title android/Pro Controller.cfg: input_menu_toggle_btn comment android/Pro Controller.cfg renamed to android/Nintendo Switch Pro Controller.cfg, and added input_menu_toggle_btn comment Aug 1, 2024
removed input_device_display_name = "Nintendo Switch Pro Controller" -- not needed
@davidhedlund davidhedlund changed the title android/Pro Controller.cfg renamed to android/Nintendo Switch Pro Controller.cfg, and added input_menu_toggle_btn comment android/Pro Controller.cfg updated Aug 1, 2024
@davidhedlund davidhedlund changed the title android/Pro Controller.cfg updated android: Update and rename Pro Controller.cfg to Nintendo Switch Pro Controller.cfg Aug 1, 2024
@davidhedlund davidhedlund changed the title android: Update and rename Pro Controller.cfg to Nintendo Switch Pro Controller.cfg [READY] android: Update and rename Pro Controller.cfg to Nintendo Switch Pro Controller.cfg Aug 17, 2024
Copy link
Member

@RobLoach RobLoach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind fixing the conflict? Thanks.

@davidhedlund
Copy link
Contributor Author

Mind fixing the conflict? Thanks.

I cannot see any conflicts any more at https://github.com/libretro/retroarch-joypad-autoconfig/pull/1158/checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants