-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[READY] android: Update and rename Pro Controller.cfg
to Nintendo Switch Pro Controller.cfg
#1158
Open
davidhedlund
wants to merge
11
commits into
libretro:master
Choose a base branch
from
davidhedlund:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
davidhedlund
commented
Aug 1, 2024
•
edited
Loading
edited
- Updated the input variables
- Streamlined the autoconfig file by removing comments and blank lines, sorting variables, and adding labels.
- Older Android kernels identify the controller as "Pro Controller," whereas newer kernels recognize it as "Nintendo Switch Pro Controller," which provides a more complete name.
input_menu_toggle_btn is bound to the Capture button (Circle label) instead of the the Home button (Home label), because the Home button is bound to Android's Home button.
…r.cfg "Nintendo Switch Pro Controller" not "Pro Controller"
davidhedlund
changed the title
android/Pro Controller.cfg: input_menu_toggle_btn comment
Aug 1, 2024
android/Pro Controller.cfg
renamed to android/Nintendo Switch Pro Controller.cfg
, and added input_menu_toggle_btn comment
removed input_device_display_name = "Nintendo Switch Pro Controller" -- not needed
davidhedlund
changed the title
Aug 1, 2024
android/Pro Controller.cfg
renamed to android/Nintendo Switch Pro Controller.cfg
, and added input_menu_toggle_btn commentandroid/Pro Controller.cfg
updated
davidhedlund
changed the title
android: Update and rename Aug 1, 2024
android/Pro Controller.cfg
updatedPro Controller.cfg
to Nintendo Switch Pro Controller.cfg
davidhedlund
changed the title
android: Update and rename
[READY] android: Update and rename Aug 17, 2024
Pro Controller.cfg
to Nintendo Switch Pro Controller.cfg
Pro Controller.cfg
to Nintendo Switch Pro Controller.cfg
Unnecessary input_device in autoconfig files generated by the android, and sdl2 controller drivers - libretro/RetroArch#16920
Removed the comments
RobLoach
requested changes
Sep 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind fixing the conflict? Thanks.
I cannot see any conflicts any more at https://github.com/libretro/retroarch-joypad-autoconfig/pull/1158/checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.