[READY] linuxraw: Create Nintendo Switch Pro Controller (non-HID) (default-off).cfg
#1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhedlund
changed the title
sdl2/Pro Controller (default-off).cfg created
davidhedlund
changed the title
sdl2/Pro Controller (default-off).cfg createdlinuxraw/Pro Controller (default-off).cfg created
davidhedlund
changed the title
linuxraw/Pro Controller (default-off).cfg createdPro Controller (default-off).cfg created
davidhedlund
changed the title
Pro Controller (default-off).cfg createdPro Controller (default-off).cfg
Removed manually added product and vendor ID variables since the were not generated by "Save Controller Profile". "The linuxraw driver uses an interface that does not provide product and vendor IDs, just a name - see JSIOCGNAME. I am not sure where the existing linuxraw autoconfig values came from, but since driver always sets these as 0, those extra identifiers can not help in matching the correct profile..." - libretro/RetroArch#16828 (comment)
# The autoconfig file remains enabled by default, even though the widely-used Nintendo Switch Pro Controller (nintendo-hid version) file is also active. Generally, we disable autoconfig files that create conflicts with input_driver and input_device. However, since linuxraw relies on input_device, and the variable values differ between the HID and non-HID versions of this controller, both autoconfig files can coexist without issues.
davidhedlund
changed the title
Pro Controller (default-off).cfgPro Controller.cfg
# The autoconfig file remains enabled by default, even though the widely-used Nintendo Switch Pro Controller (nintendo-hid version) file is also active. Generally, we disable autoconfig files that create conflicts with input_driver and input_device. However, since linuxraw relies on input_device, and the variable values differ between the HID and non-HID versions of this controller, both autoconfig files can coexist without issues.
davidhedlund
changed the title
Pro Controller.cfgPro Controller.cfg
# This file has not been evaluated. The linuxraw autoconfig files cannot be assessed in Remote RetroPad or in games until this issue is resolved: [IMPORTANT] linuxraw: Mapping variables are ineffective - https://github.com/libretro/RetroArch/issues/16856[1].
input_l_x_plus_axis = "+0" input_l_x_minus_axis = "-0" input_l_y_plus_axis = "+1" input_l_y_minus_axis = "-1" input_r_x_plus_axis = "+2" input_r_x_minus_axis = "-2" input_r_y_plus_axis = "+3" # input_r_y_minus_axis has manually been set here: Nintendo Switch Pro Controller+Linux 5.15 (non-HID) does not register thumb sticks - libretro/RetroArch#16905 input_r_y_minus_axis = "-3"
input_device_display_name = "Nintendo Switch Pro Controller (non-HID) (Bluetooth)"
removed generic comment
Removed the final comments
davidhedlund
changed the title
Pro Controller.cfgPro Controller (default-off).cfg
Disabled the controller
davidhedlund
changed the title
Pro Controller (default-off).cfgPro Controller (default-off).cfg. And create a Nintendo Co., Ltd. Pro Controller (default-off).cfg copy
USB support is not available for this controller in Linux version 5.15, only Bluetooth.
davidhedlund
changed the title
Pro Controller (default-off).cfg. And create a Nintendo Co., Ltd. Pro Controller (default-off).cfg copyPro Controller (default-off).cfg
… Pro Controller (default-off).cfg After re-evaluation, the name was corrected. The "Nintendo Switch Pro Controller" is utilized for Bluetooth connections.
davidhedlund
changed the title
Pro Controller (default-off).cfgNintendo Switch Pro Controller (default-off).cfg
input_screenshot_btn = "13"
remove input_screenshot_btn = "13" -- the screenshot button does not work
RobLoach
requested changes
Sep 28, 2024
There was a problem hiding this comment.
Could you clarify why we are adding this one when linuxraw/Nintendo Switch Pro Controller.cfg already exists?
It looks like the only difference is the A/B flipped. RetroArch uses the retropad scheme:
https://www.lakka.tv/doc/Input-settings/
…witch Pro Controller (non-HID) (default-off).cfg Added "(non-HID) " to the filename
davidhedlund
changed the title
Nintendo Switch Pro Controller (default-off).cfgNintendo Switch Pro Controller (non-HID) (default-off).cfg
I added "(non-HID) " to the filename for this PR.
That is incorrect. The HID file have completely different bindings. Have a look at: https://github.com/libretro/retroarch-joypad-autoconfig/blob/master/linuxraw/Nintendo%20Switch%20Pro%20Controller.cfg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.