Skip to content

fix(bulk): Skip and log conflict when moving holdings #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

fix(bulk): Skip and log conflict when moving holdings #1601

merged 1 commit into from
Jun 16, 2025

Conversation

olovy
Copy link
Contributor

@olovy olovy commented Jun 13, 2025

  • Skip and log ConflictingHoldException in bulk update (same behavior as bulk create)
  • Log to standard FAILED.txt and ERRORS.txt so that failed docs are included in count.
  • Make the above logs available to scripts through reportFailed() on DocumentItem

@olovy
fix(bulk): Skip and log conflict when moving holdings
0702296 
- Skip and log ConflictingHoldException in bulk update (same behavior as
  bulk create)
- Log to standard FAILED.txt and ERRORS.txt so that failed docs are
  included in count.
- Make the above logs available to scripts through reportFailed() on
  DocumentItem
kwahlin
kwahlin approved these changes Jun 16, 2025
View reviewed changes
Copy link
Contributor

@kwahlin kwahlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olovy olovy merged commit a933c21 into develop Jun 16, 2025
1 check passed
@olovy olovy deleted the bugfix/bulk-move-holding-conflict branch June 16, 2025 11:12
olovy added a commit that referenced this pull request Jun 16, 2025
@olovy
fix(bulk): Skip and log conflict when moving holdings (#1601)
fd52f16 
- Skip and log ConflictingHoldException in bulk update (same behavior as
  bulk create)
- Log to standard FAILED.txt and ERRORS.txt so that failed docs are
  included in count.
- Make the above logs available to scripts through reportFailed() on
  DocumentItem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwahlin kwahlin kwahlin approved these changes

@andersju andersju Awaiting requested review from andersju

@kaipoykio kaipoykio Awaiting requested review from kaipoykio

@jannistsiroyannis jannistsiroyannis Awaiting requested review from jannistsiroyannis

@lrosenstrom lrosenstrom Awaiting requested review from lrosenstrom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olovy @kwahlin