Bots that are disabled or have tos violation aren't shown anymore

[AttackingOrDefending]

Type of pull request:

• Bug fix
• Feature
• Other

Description:

Disabled bots (i.e. account closed) and bots with tos violation aren't shown in the bot list anymore. The change was done here.

Related Issues:

None

Checklist:

• I have read and followed the contribution guidelines.
• I have added necessary documentation (if applicable).
• The changes pass all existing tests.

Screenshots/logs (if applicable):

[MarkZH]

Are these fields in the UserProfileType and PublicDataType still necessary? The tosViolation is field still sent, but it will now always be false, right?

lichess-bot/lib/lichess_types.py

Line 60 in b1b5c7b

tosViolation: bool

lichess-bot/lib/lichess_types.py

Line 266 in b1b5c7b

tosViolation: bool

And this can possibly be removed from the test:

lichess-bot/test_bot/test_lichess.py

Line 44 in b1b5c7b

"seenAt": 1669272254317, "title": "BOT", "tosViolation": True,

[AttackingOrDefending]

They weren't needed in UserProfileType so they were removed (both tos violation and disabled). They are still present at PublicDataType and can be both true or false (so the line from the tests cannot be removed) it's just that these bots aren't shown in the /api/bot/online endpoint.